Repository navigation
Check if manager is None instead of Falsy - #66
Open
wkleinheerenbrink wants to merge 2 commits into
Open
wkleinheerenbrink wants to merge 2 commits into
wkleinheerenbrink wants to merge 2 commits into
Conversation
A custom defined manager will be overridden by the `_default_manager` when the custom manager returns `QuerySet<[]>`, because `bool(QuerySet<[]>) is False`
Owner
|
Many thanks for the contribution, Wouter. Do you think you could include a test for this so we can ensure proper functionality in the future? |
|
@wkleinheerenbrink I don't know what the test should be. I tried to write one, but the behaviour doesn't change for fields that have a unique attribute. What scenario did you have that made it matter which manager is used if the queryset is empty? |
Owner
|
Hmm. I re-opened this with the intention of merging it, but it seems like the tests are now failing, and I don't have time at the moment to figure out why. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom defined manager will be overridden by the
_default_managerwhen the custom manager returnsQuerySet<[]>, becausebool(QuerySet<[]>) is FalseI haven't had time to write the unit test and test on all versions, but I would like to provide you with the fix already.