Conversation
|
|
brichet
force-pushed
the
drop_lerna_dependency
branch
from
ada0b3a to
641efde
Compare
jtpio
left a comment
jtpio
left a comment
There was a problem hiding this comment.
Thanks!
Looks like it picked a small conflict from the latest patch release.
Otherwise the diff looks good.
| @click.option("--skip-if-dirty", default=False, is_flag=True) | ||
| @click.argument("spec", nargs=1) | ||
| def bump(force, skip_if_dirty, spec): | ||
| def bump(skip_if_dirty, spec): |
There was a problem hiding this comment.
Wondering if we could put this script under tests on CI, just checking if we are able to bump versions?
This could be done separately though, if we are confident the changes still ensure the current release process works as expected.
There was a problem hiding this comment.
Isn't it already the case with check_release workflow ?
https://github.com/jupyterlab/jupyter-chat/actions/runs/23946018613/job/69842286553#step:4:300
There was a problem hiding this comment.
Yeah by default it tests bumping as next iirc. I meant checking that passing another value like the version number also works fine.
brichet
force-pushed
the
drop_lerna_dependency
branch
from
641efde to
adb5099
Compare
2 participants
This PR drop the lerna dependency.
For the reference, it is already done or WIP in main Jupyter projects:
lernajupyterlite/jupyterlite#1843lernajupyter/notebook#7882