Skip to content

perf: streamline SSH client creation and account matching logic#1972

Open
fit2bot wants to merge 7 commits into
devfrom
pr@dev@feat_sftp_support_keyboard_interactive
Open

perf: streamline SSH client creation and account matching logic#1972
fit2bot wants to merge 7 commits into
devfrom
pr@dev@feat_sftp_support_keyboard_interactive

Revert "fix: reorder keyboard authentication logic in SSH client opti…

0f732f2
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 28, 2026 in 34s

Annotations

Check failure on line 98 in pkg/auth/direct_sftp_asset_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=jumpserver_koko&issues=AZ0pnMrW44rUEC3psUNX&open=AZ0pnMrW44rUEC3psUNX&pullRequest=1972

Check failure on line 41 in pkg/auth/direct_sftp_asset_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "otp required" 5 times.

See more on https://sonarcloud.io/project/issues?id=jumpserver_koko&issues=AZ0pnMrW44rUEC3psUNW&open=AZ0pnMrW44rUEC3psUNW&pullRequest=1972

Check failure on line 41 in pkg/auth/direct_sftp_asset_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Verification code:" 5 times.

See more on https://sonarcloud.io/project/issues?id=jumpserver_koko&issues=AZ0pnMrW44rUEC3psUNV&open=AZ0pnMrW44rUEC3psUNV&pullRequest=1972

Check failure on line 243 in pkg/auth/direct_sftp_asset.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "direct sftp auth canceled" 4 times.

See more on https://sonarcloud.io/project/issues?id=jumpserver_koko&issues=AZ0pnMth44rUEC3psUNY&open=AZ0pnMth44rUEC3psUNY&pullRequest=1972

Check warning on line 78 in pkg/auth/direct_sftp_asset_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary variable declaration and use the expression directly in the condition.

See more on https://sonarcloud.io/project/issues?id=jumpserver_koko&issues=AZ0pnMrW44rUEC3psUNS&open=AZ0pnMrW44rUEC3psUNS&pullRequest=1972

Check warning on line 85 in pkg/auth/direct_sftp_asset_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary variable declaration and use the expression directly in the condition.

See more on https://sonarcloud.io/project/issues?id=jumpserver_koko&issues=AZ0pnMrW44rUEC3psUNT&open=AZ0pnMrW44rUEC3psUNT&pullRequest=1972

Check failure on line 147 in pkg/auth/direct_sftp_asset.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 24 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=jumpserver_koko&issues=AZ0pnMth44rUEC3psUNZ&open=AZ0pnMth44rUEC3psUNZ&pullRequest=1972

Check failure on line 33 in pkg/auth/direct_sftp_asset_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "session-1" 3 times.

See more on https://sonarcloud.io/project/issues?id=jumpserver_koko&issues=AZ0pnMrW44rUEC3psUNU&open=AZ0pnMrW44rUEC3psUNU&pullRequest=1972