Fix WooCommerce tax display options not being corrected on install (CO-3447) - #55
Open
MagnusPienknyJTL (jtlmagnus) wants to merge 1 commit into
Open
Conversation
…O-3447) The previous fix checked get_option(..., false) === false before forcing 'incl', but WooCommerce already writes its own 'excl' default into wp_options before the connector's activation hook runs, so the check never triggered and the QA-reported bug persisted. Restores the !== 'incl' comparison and additionally gates the correction behind a new isFirstInstall() check so a shop owner's deliberate later change is not reverted on plugin re-activation. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
woocommerce_tax_display_shop/woocommerce_tax_display_cartfix from PR fix: set WooCommerce tax display options on plugin activation #51 doesn't work on a real install: WooCommerce already writes its own'excl'default intowp_optionsbefore the connector's activation hook runs, so theget_option(..., false) === falsecheck introduced in a later "potential fix for pull request finding" commit never triggers.!== 'incl'comparison so the pre-existing'excl'default is actually corrected to'incl'.isFirstInstall()check (based onConfig::OPTIONS_INSTALLED_VERSION), so a shop owner's deliberate later change isn't reverted every time the plugin is re-activated — the concern the weakened check was originally trying (incorrectly) to address.Test plan
vendor/bin/phpunit tests/src/JtlConnectorAdminTest.php— new regression test covers the WooCommerce'excl'-default scenario, plus tests forisFirstInstall()composer run phpcs/composer run phpstan— cleanvendor/bin/phpunitrun — no new failures (2 pre-existing unrelated failures)🤖 Generated with Claude Code