bugfix/CO-3434_manufacturer_linking_not_set - #42
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
wp_insert_term returns an array, not a WP_Term object. The subsequent instanceof WP_Term check always failed for new manufacturers, so the endpoint ID was never set and the link table entry was never created. Convert the array result to a WP_Term via get_term_by before proceeding.
Patrick Gugelsberger (Patrick-Gugelsberger)
marked this pull request as ready for review
May 26, 2026 14:38
Patrick Gugelsberger (Patrick-Gugelsberger)
requested a review
from a team
as a code owner
May 26, 2026 14:38
MagnusPienknyJTL (jtlmagnus)
approved these changes
Jun 3, 2026
MagnusPienknyJTL (jtlmagnus)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-drafted on push to
bugfix/CO-3434_manufacturer_linking_not_set. Replace this body with details before requesting review.