Skip to content

feat(modeling): avoid computing planes multiple time in expandShell - #1496

Merged
z3dev merged 1 commit into
jscad:masterfrom
MaccheroniCode:feat/duplicated-work
Nov 7, 2026
Merged

z3dev merged 1 commit into
jscad:masterfrom
MaccheroniCode:feat/duplicated-work

Conversation

@B3rn475

@B3rn475 B3rn475 commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

on-behalf-of: @MaccheroniCode info@maccheronicode.it

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

Note: please do NOT include build files (those generate by the build-xxx commands) with your PR,

Thank you for your help in advance, much appreciated !

@z3dev
z3dev requested review from hrgdavor, platypii and z3dev November 6, 2026 23:37
@z3dev

z3dev commented Nov 6, 2026

Copy link
Copy Markdown
Member

@B3rn475 These changes look nice. Thanks. Just a quick check... Did all the tests pass?

@B3rn475

B3rn475 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@B3rn475 These changes look nice. Thanks. Just a quick check... Did all the tests pass?

They were all passing.

@z3dev z3dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@B3rn475 Thanks again. Looks good.

@z3dev
z3dev merged commit 720f368 into jscad:master Nov 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants