Repository navigation
feat(modeling): add center option to torus - #1492
Conversation
| } | ||
| return extrudeRotate(extrudeOptions, innerCircle) | ||
| let result = extrudeRotate(extrudeOptions, innerCircle); | ||
| if (center[0] !== 0 && center[1] !== 0 && center[2] !== 0) { |
There was a problem hiding this comment.
Maybe this? As the center could be [0, 0, 5]
if ((center[0] !== 0) || (center[1] !== 0) || (center[2] !== 0)) {
There was a problem hiding this comment.
Done
Thank You for noticing.
Sorry for the bad copy-paste from another attempt.
Add center option to torus. This aligns the torus options to the rest of the primitives where a center can be specified. Co-authored-by: Simone Cattaneo <katta@maccheronicode.it> on-behalf-of: @MaccheroniCode <info@maccheronicode.it>
55c289d to
845364c
Compare
|
QQ: Will this change be ported to V3 automatically or should we propose that change too? While I used JSCAD for years, I'm new to its development workflow and I would like to be sure to follow the best practices. |
|
I sync V2 and V3 periodically so the changes will come into V3. If you want the changes faster then best open a new pull request. I will release V3 soon. |
|
Not in a hurry. I was just wondering what was the "standard procedure". If V3 is coming soon, I better start migrating my models. |
|
subscribed :) ... join us on discord if not already |
Add center option to torus.
This aligns the torus options to the rest of the primitives where a center can be specified.
#1476
All Submissions:
Thank you for your help in advance, much appreciated !