Skip to content

Avoid direct constructors from JRuby #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 2 commits into from
Apr 9, 2026
Merged

Avoid direct constructors from JRuby #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17dc5ab
Avoid direct constructors from JRuby
headius Apr 8, 2026
654046f
Bump JRuby to 9.2.1.0 for CharSequence newString
headius Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Mavenfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ plugin :clean do
'failOnError' => 'false' )
end

jar 'org.jruby:jruby-core', '9.2.0.0', :scope => :provided
jar 'org.jruby:jruby-core', '9.2.1.0', :scope => :provided
# for invoker generated classes we need to add javax.annotation when on Java > 8
jar 'javax.annotation:javax.annotation-api', '1.3.1', :scope => :compile
jar 'org.junit.jupiter:junit-jupiter', '5.11.4', :scope => :test
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/jruby/ext/openssl/StringHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ static RubyString newString(final Ruby runtime, final byte[] bytes, final int co
}

static RubyString newString(final Ruby runtime, final CharSequence chars) {
return new RubyString(runtime, runtime.getString(), chars, ASCIIEncoding.INSTANCE);
return RubyString.newString(runtime, chars, ASCIIEncoding.INSTANCE);
}

static ByteList setByteListShared(final RubyString str) {
Expand All @@ -73,12 +73,12 @@ static ByteList setByteListShared(final RubyString str) {

static RubyString newUTF8String(final Ruby runtime, final ByteList bytes) {
ByteList byteList = new ByteList(RubyEncoding.encodeUTF8(bytes), UTF8Encoding.INSTANCE, false);
return new RubyString(runtime, runtime.getString(), byteList);
return RubyString.newString(runtime, byteList);
}

static RubyString newUTF8String(final Ruby runtime, final CharSequence chars) {
ByteList byteList = new ByteList(RubyEncoding.encodeUTF8(chars), UTF8Encoding.INSTANCE, false);
return new RubyString(runtime, runtime.getString(), byteList);
return RubyString.newString(runtime, byteList);
}

static RubyString newStringFrozen(final Ruby runtime, final ByteList bytes) {
Expand Down
Loading