jrl_option: fix condition handling on reconfigure - #867
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
nim65s
force-pushed
the
fix-jrl-options-cond
branch
from
August 13, 2026 10:12
024fefb to
61250c3
Compare
nim65s
approved these changes
Aug 13, 2026
nim65s
left a comment
nim65s
left a comment
Collaborator
There was a problem hiding this comment.
can't say I understand everything here, so I guess I'll trust you on this one 😅
Collaborator
Author
When unsure, trust the unit tests ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses Simple-Robotics/proxsuite#437 (comment)