Mega Menu #6230
Conversation
🦋 Changeset detectedLatest commit: a237915 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| const handleKeyDown = (event: KeyboardEvent<HTMLLIElement>) => { | ||
| rest.onKeyDown?.(event); | ||
| if (event.key === " " || event.key === "Enter") { |
There was a problem hiding this comment.
Handling space and enter here seems strange, plus can't we just rely on the native link behaviour?
There was a problem hiding this comment.
space is not handled by the link. i have asked this question to design if we want to have space to select the menuItem.
There was a problem hiding this comment.
Design said it should react same as Salt menu item. By clicking space user should able to select the item.
CC: @honey-chang
| children?: ReactNode; | ||
| } | ||
|
|
||
| export const MegaMenuItemContent = forwardRef< |
There was a problem hiding this comment.
What benefit does this component provide?
There was a problem hiding this comment.
this was added to replicate the padding: var(--salt-spacing-75) 0 we have applied on the text content so that icon aligns to the start.
3 participants
Adding Mega Menu