Skip to content

Refactor Tabs#6218

Merged
joshwooding merged 3 commits intomainfrom
experiment-tabs-2
Apr 22, 2026
Merged

Refactor Tabs#6218
joshwooding merged 3 commits intomainfrom
experiment-tabs-2

Conversation

@joshwooding
Copy link
Copy Markdown
Contributor

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
saltdesignsystem Ready Ready Preview, Comment Apr 22, 2026 3:20pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 7, 2026

⚠️ No Changeset found

Latest commit: 4e983a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshwooding joshwooding marked this pull request as ready for review April 15, 2026 18:35
@joshwooding joshwooding force-pushed the experiment-tabs-2 branch 2 times, most recently from 71e33f6 to cc1da85 Compare April 15, 2026 20:50
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Apr 15, 2026
@github-actions github-actions Bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Apr 15, 2026
jake-costa
jake-costa previously approved these changes Apr 16, 2026
@joshwooding joshwooding changed the title Experimental Tabs Refactor Tabs Apr 17, 2026
Comment thread site/docs/components/tabs/examples.mdx Outdated
Comment thread site/docs/components/tabs/usage.mdx
Comment thread packages/lab/src/tabs-next/TabOverflowContext.ts Outdated
@tycup
Copy link
Copy Markdown
Contributor

tycup commented Apr 21, 2026

Given this Tab example
When in mobile viewport and I tab into the Tab,
Then press the right arrow key to focus on the overflow icon
Then trigger it with space/enter, the focus moves to the first item in the overflow menu (which is disabled).
Using the arrow keys to navigate through the list does not move focus down the list of overflow items

Also gets stuck in this disabled example

Comment thread packages/lab/src/tabs-next/TabsNext.tsx
tycup
tycup previously approved these changes Apr 22, 2026
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Apr 22, 2026
@github-actions github-actions Bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Apr 22, 2026
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Apr 22, 2026
@joshwooding joshwooding requested a review from tycup April 22, 2026 15:18
@github-actions github-actions Bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Apr 22, 2026
@joshwooding joshwooding merged commit a79f473 into main Apr 22, 2026
14 of 15 checks passed
@joshwooding joshwooding deleted the experiment-tabs-2 branch April 22, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants