Skip to content

Add Side Panel to Lab#6133

Closed
wemmyo wants to merge 64 commits into
mainfrom
create-inlaid-panel
Closed

Add Side Panel to Lab#6133
wemmyo wants to merge 64 commits into
mainfrom
create-inlaid-panel

Conversation

@wemmyo
Copy link
Copy Markdown
Contributor

@wemmyo wemmyo commented Mar 10, 2026 •
edited
Loading

Closes #3734

  • Add side panel component to lab
  • Side panel support variants primary, secondary and tertiary similar to Drawer for the background colour
  • Side panel relies on other layout component for layout structure
  • There's an a11y requirement for focus to move from trigger to side panel when open and back to trigger when closed, SidePanelGroup automatically handles that but for more complex cases users can handle that without the SidePanelGroup

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 10, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
saltdesignsystem Ready Ready Preview, Comment Apr 2, 2026 3:26pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 10, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 1d30c64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@salt-ds/lab Minor
@salt-ds/data-grid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wemmyo
wemmyo commented Mar 31, 2026
View reviewed changes
Comment thread packages/lab/src/side-panel/SidePanelCloseButton.tsx Outdated
wemmyo
wemmyo commented Mar 31, 2026
View reviewed changes
Comment thread packages/lab/stories/side-panel/side-panel.qa.stories.tsx
Copy link
Copy Markdown
Contributor Author

@wemmyo wemmyo Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been able to get this to work properly. Side panel opening animation is the issue

wemmyo
wemmyo commented Mar 31, 2026
View reviewed changes
Comment thread packages/lab/src/side-panel/SidePanelGroup.tsx
/**
* Default open state when initially rendered
*/
defaultOpen?: boolean;
Copy link
Copy Markdown
Contributor Author

@wemmyo wemmyo Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disable opening animation when defaultOpen is true?

wemmyo
wemmyo commented Mar 31, 2026
View reviewed changes
Comment thread site/docs/components/side-panel/examples.mdx
Copy link
Copy Markdown
Contributor Author

@wemmyo wemmyo Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs is missing the mention of the --saltSidePanel-width for updating width. Not quite sure where to insert it. This isn't common with our other components

@wemmyo wemmyo marked this pull request as draft April 21, 2026 08:23
@mark-tate
Copy link
Copy Markdown
Contributor

mark-tate commented Apr 21, 2026

moved this work to PR #6221

@mark-tate mark-tate closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create RC for Side Panel component (previously Inlaid Drawer) in Labs

2 participants

@wemmyo @mark-tate