Skip to content

refactor: support INTERNAL_buildStoreRev3 + drop support for older version #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arjunvegda merged 3 commits into from
May 6, 2026
Merged

refactor: support INTERNAL_buildStoreRev3 + drop support for older version #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcc378f
refactor: support INTERNAL_buildStoreRev3 + drop support for older ve…
arjunvegda May 1, 2026
0713c9d
Merge remote-tracking branch 'origin/main' into refactor/jotai-devtoo…
arjunvegda May 6, 2026
f0f92cf
refactor: bump jotai to latest + update peer deps
arjunvegda May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

## ☝️ Prerequisites

- Jotai version `>=v2.14.0`
- Jotai version `>=v2.20.0`
- React version `>=17.0.0`

## 📦 Setup
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
"jest": "^30.3.0",
"jest-environment-jsdom": "^30.1.2",
"jest-watch-typeahead": "^3.0.1",
"jotai": "^2.19.0",
"jotai": "2.20.0",
"jotai-tanstack-query": "^0.9.0",
"lint-staged": "^16.4.0",
"postcss": "^8.5.8",
Expand All @@ -160,7 +160,7 @@
"webpack": "^5.105.4"
},
"peerDependencies": {
"jotai": ">=2.14.0",
"jotai": ">=2.20.0",
"react": ">=17.0.0"
},
"dependencies": {
Expand Down
16 changes: 8 additions & 8 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/utils/internals/compose-with-devtools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { Atom, WritableAtom } from 'jotai';
import { INTERNAL_overrideCreateStore } from 'jotai/vanilla';
import {
INTERNAL_buildStoreRev2 as INTERNAL_buildStore,
INTERNAL_initializeStoreHooksRev2 as INTERNAL_initializeStoreHooks,
INTERNAL_buildStoreRev3 as INTERNAL_buildStore,
INTERNAL_initializeStoreHooksRev3 as INTERNAL_initializeStoreHooks,
} from 'jotai/vanilla/internals';
import {
AnyAtom,
Expand Down Expand Up @@ -170,7 +170,7 @@ const createDevStore = (): StoreWithDevMethods => {
undefined,
storeHooks,
undefined,
(_store, atom, get, set, ...args) => {
(_buildingBlocks, _store, atom, get, set, ...args) => {
if (inRestoreAtom) {
return set(atom, ...(args as any));
}
Expand Down
Loading