Paper cuts#8
Open
joshpitzalis wants to merge 2 commits intomainfrom
Open
Conversation
Separates business logic (join/rename/leave/close validation and state transitions) from WebSocket transport. WorkshopRoom is now a thin shell that delegates to WorkshopState and applies result objects. All 11 business rules are testable without WebSocket mocking. Closes #3 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
New hook wraps useWorkshopSocket with named action methods (updateStatus, leave, rename, closeWorkshop) and reactive error/renamedTo state. Both route files now have zero ClientMessage knowledge. Also adds vitest.config.ts to isolate test runner from SSR plugins, and fixes WorkshopRoom test that was broken by happy-dom stripping the Upgrade header. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.