refactor pokemon and item data by joos-too · Pull Request #213 · joos-too/Pokemon-Soullink-Tracker

joos-too · 2026-04-27T11:05:22Z

see attached issues for change log
please review/test thoroughly because there are a lot of changes
please pay special attention to how missing images for custom pokemon names/items currently look
-> needs a better solution i guess

After merging: import migrated database json to firebase!

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

…licity Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

…ost places Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

… use pokedex-promise-v2 - working in progress on translating new evolutions generated from generate-pokemon.mjs - renamed generate-pokemon-de.mjs to generate-pokemon.mjs and added all scripts to package.json Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

- add translations for items and some location fallback logic Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

… data via new pokeapi-static-client.mjs Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

… fix readme Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

- remove alt texts in many places where they are not needed because they lead to unwanted visual inconsistencies - fix pokemon sprites in DeleteLinkModal.tsx and SelectLossModal.tsx to use generationSpritePath Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

FreakMediaLP · 2026-05-18T11:44:38Z

(With custom tracker enabled) If you add an Item, by simply entering its name, without selecting it, it wont be detected correctly.

For Pokémon it works as intended, as soon as you enter the correct name (even with custom tracker off), it automatically selects the Pokémon and shows the Sprite

FreakMediaLP · 2026-05-18T11:50:15Z

The custom-tracker-toggle is way to big in my oppinion, it should not be bigger than the version and ruleset selection, maybe just a small text (left) and a toggle (right), same as on the settings page.
Also I would rename it, so sth like "Version Override" (sounds cooler and is shorter), also the current naming could be missleading, so someone would think, that without this setting on, only the pokemon from exacly that generation would be available.

FreakMediaLP · 2026-05-18T11:53:44Z

Side note, all three item-categories use the same tooltip (evolution stone), rename it to "Item".
Also for consistency, maybe rename the "Stones" category (in this modal) to "Evolution Stones", as we currently have "Stones" and "Mega Stones"

FreakMediaLP · 2026-05-18T11:56:46Z

I dont know what is happening here, would like some info for better understanding, are this Gen 7+ Items, which dont have sprites in PokéAPI yet?

FreakMediaLP

Check comments (pokemon data cleanup looks good so far, could not find an issue)

Edit: Found some ↓↓↓

FreakMediaLP · 2026-05-18T14:20:51Z

In ORAS, Nosepass evolution is supposed to be in "New Mauville", but it shows "Thunder Stone", which was added in Gen8

Edit: Exact same issue for "Magneton -> Magnezone in ORAS", only that it dosnt show any evolution method at all

FreakMediaLP · 2026-05-18T14:25:40Z

Edit: Exact same issue for "Magneton -> Magnezone in ORAS", only that it dosnt show any evolution method at all <img

Maybe check all evolution methods again, I just checked Eevee and these two and all had something wrong

joos-too · 2026-05-18T14:48:29Z

In ORAS, Nosepass evolution is supposed to be in "New Mauville", but it shows "Thunder Stone", which was added in Gen8

Edit: Exact same issue for "Magneton -> Magnezone in ORAS", only that it dosnt show any evolution method at all

I'll check filters again. Probably something wrong.
Edit: Forget to filter it out because it wasn't in this List: https://www.pokewiki.de/Liste_der_speziellen_Entwicklungen.

joos-too · 2026-05-18T14:49:54Z

Edit: Exact same issue for "Magneton -> Magnezone in ORAS", only that it dosnt show any evolution method at all <img

Maybe check all evolution methods again, I just checked Eevee and these two and all had something wrong

The missing locations for ORAS is a pokeapi data problem in my opinion, so best to open a pr there, because pokemon.ts is generated and shouldn't be edited. They are probably all missing because Evolution Locations like that didn't exist back in gen 3 and they didn't add them afterwards.

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

FreakMediaLP · 2026-05-19T08:25:41Z

Edit: Forget to filter it out because it wasn't in this List: https://www.pokewiki.de/Liste_der_speziellen_Entwicklungen.

They are in the list, or did I miss something?

joos-too · 2026-05-19T08:58:12Z

Edit: Forget to filter it out because it wasn't in this List: https://www.pokewiki.de/Liste_der_speziellen_Entwicklungen.

They are in the list, or did I miss something?

Yes i meant the Gen 8 Stone Evolution i filtered out. nosepass is missing there. I only used this list to adjust filters and didn't check all evo locations.

FreakMediaLP · 2026-05-19T09:15:31Z

Change made, waiting for approval PokeAPI/pokeapi#1525

…ally resolve item slugs Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

…ion tooltips Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

… all pokemon in all games Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

…alization, toggle size adjustments and adding it to settingspage Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

joos-too · 2026-05-23T16:34:53Z

I made the suggested changes and also added generation sprite fallbacks for all gens.
This is needed if somebody is combining generation specific sprites with version override setting so sprites aren't missing.

We should also think about, if we want to merge this pr before the pokeapi changes are live (and deploy the pokemon.ts changes some other time) or if we wait.

After merging: import migrated database json to firebase!

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

refactor pokemon data and change to id based saving of pokemon

1ecfbb6

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

joos-too self-assigned this Apr 27, 2026

joos-too linked an issue Apr 27, 2026 that may be closed by this pull request

cleanup pokemon data #211

Open

8 tasks

joos-too added 3 commits April 27, 2026 14:39

reduced pokemon.ts file size by optimizing data structure

c2ebd31

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

fix location generation and rename data file to locations.ts for simp…

93682c4

…licity Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

initially add pokemon up to gen 9 and remove name to id fallback in m…

be56878

…ost places Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

joos-too linked an issue Apr 28, 2026 that may be closed by this pull request

itemTracker followup #214

Open

6 tasks

joos-too changed the title ~~refactor pokemon data and change to id based saving of pokemon~~ refactor pokemon and item data Apr 28, 2026

joos-too added 3 commits April 28, 2026 15:03

- change level-up to levelaufstieg in german

5b6cb28

- add translations for items and some location fallback logic Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

remove unnecessary convert-itemlists.mjs script

d35d339

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

FreakMediaLP requested review from FreakMediaLP and removed request for FreakMediaLP April 28, 2026 16:38

joos-too marked this pull request as draft April 29, 2026 13:28

joos-too added 10 commits April 30, 2026 11:31

added new evolution methods and changed scripts to use static pokeapi…

8a7b078

… data via new pokeapi-static-client.mjs Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

change evolutionMethodFilter.ts to use new evolution method slugs and…

c28dc0f

… fix readme Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

fix evolution methods and add new version + gen filters

701d778

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

fix evolution methods and add new version + gen filters 2

cc140c3

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

add first draft of allow all pokemon and items toggle

be92eae

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

allow custom pokemon and item names and handle missing item images

a7be733

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

changed migrate script to preserve custom pokemon names

67a392f

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

Fix: reduce code duplication by adding resolvePokemonDisplay helper

68704a4

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

Fix SuggestionInput.tsx

8cf9ba1

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

joos-too requested a review from FreakMediaLP May 17, 2026 14:48

joos-too marked this pull request as ready for review May 17, 2026 14:48

FreakMediaLP requested changes May 18, 2026

View reviewed changes

FreakMediaLP reviewed May 18, 2026

View reviewed changes

Comment thread src/data/pokemon.ts

FreakMediaLP reviewed May 18, 2026

View reviewed changes

Comment thread src/data/pokemon.ts

FreakMediaLP reviewed May 18, 2026

View reviewed changes

Comment thread src/services/evolutionMethodFilter.ts

FreakMediaLP reviewed May 18, 2026

View reviewed changes

Comment thread src/services/evolutionMethodFilter.ts

Add evolution method filter for "voluminas"

3487409

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

joos-too added 4 commits May 23, 2026 17:16

Add findItemByName helper and update ItemSuggestionInput to automatic…

7ebda9f

…ally resolve item slugs Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

Update localization: clarify "Evolution Stones" tab and improve locat…

dee1039

…ion tooltips Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

Fixed generation sprite fallbacks in the context of possibly allowing…

4a17351

… all pokemon in all games Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

Add finalized version of "Version Override" feature with improved loc…

9a9db72

…alization, toggle size adjustments and adding it to settingspage Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

joos-too requested a review from FreakMediaLP May 23, 2026 16:31

fix fallback rules to reduce sprite diversity and improve clarity

2951336

Signed-off-by: Jan L <80320565+joos-too@users.noreply.github.com>

Conversation

joos-too commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

After merging: import migrated database json to firebase!

Uh oh!

FreakMediaLP commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FreakMediaLP commented May 18, 2026

Uh oh!

FreakMediaLP commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FreakMediaLP commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FreakMediaLP left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FreakMediaLP commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FreakMediaLP commented May 18, 2026

Uh oh!

joos-too commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joos-too commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FreakMediaLP commented May 19, 2026

Uh oh!

joos-too commented May 19, 2026

Uh oh!

FreakMediaLP commented May 19, 2026

Uh oh!

joos-too commented May 23, 2026

After merging: import migrated database json to firebase!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joos-too commented Apr 27, 2026 •

edited

Loading

FreakMediaLP commented May 18, 2026 •

edited

Loading

FreakMediaLP commented May 18, 2026 •

edited

Loading

FreakMediaLP commented May 18, 2026 •

edited

Loading

FreakMediaLP left a comment •

edited

Loading

FreakMediaLP commented May 18, 2026 •

edited

Loading

joos-too commented May 18, 2026 •

edited

Loading

joos-too commented May 18, 2026 •

edited

Loading