Skip to content

[7.0] Removes some inline deprecations about invalid arguments in extensions#47945

Open
laoneo wants to merge 13 commits into
joomla:7.0-devfrom
Digital-Peak:remove/inline-deprecations
Open

[7.0] Removes some inline deprecations about invalid arguments in extensions#47945
laoneo wants to merge 13 commits into
joomla:7.0-devfrom
Digital-Peak:remove/inline-deprecations

Conversation

@laoneo

@laoneo laoneo commented Jun 12, 2026

Copy link
Copy Markdown
Member
  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Removes some inline deprecations for arguments which are passed in core correctly. When extension are using these classes outside the MVC context without booing the component first, then it might use adaptions, therefor this pr is done against 7.0.

Testing Instructions

  • Browsing around
  • Create a custom field
  • Create an article
  • Run the smart search indexer

Actual result BEFORE applying this Pull Request

All is working.

Expected result AFTER applying this Pull Request

All is working.

Link to documentations

Please select:

@laoneo laoneo added the b/c break This item changes the behavior in an incompatible why. HEADS UP label Jun 12, 2026
@laoneo laoneo changed the title [7.0] Removes some inline deprecations about invalid arguments in components [7.0] Removes some inline deprecations about invalid arguments in extensions Jun 12, 2026
Comment thread administrator/components/com_finder/src/Indexer/Query.php
@laoneo laoneo added the Architecture Pull requests which improve the architecture. label Jun 18, 2026
@joomdonation

Copy link
Copy Markdown
Contributor

All looks good to me now, made some quick tests as well. However, we currently have error with DebugIndexer. The error details is:

{"error":true,"code":0,"message":"Joomla\\Component\\Finder\\Administrator\\Indexer\\DebugAdapter::__construct(): Argument #1 ($dispatcher) must be of type Joomla\\Event\\DispatcherInterface, array given

But it is not related to this PR. Maybe we have this problem at earlier version like 6.1, but no-one noticed.

@laoneo

laoneo commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

It is noticed #47916.

@joomdonation

Copy link
Copy Markdown
Contributor

It is noticed #47916.

Ah, OK, thanks for the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Pull requests which improve the architecture. b/c break This item changes the behavior in an incompatible why. HEADS UP PR-7.0-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants