Skip to content

Removes some inline deprecations about invalid arguments in extensions #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laoneo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removes some inline deprecations about invalid arguments in extensions #668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions updates/64-70/removed-backward-incompatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,3 +398,24 @@ Factory::getApplication()->bootComponent('messages')->getMVCFactory()
Factory::getContainer()->get(ApiRouter::class);
$value = $app->getInput();
```

## Database is required in extension classes
- PR: https://github.com/joomla/joomla-cms/pull/47945
- Files:
- /administrator/components/com_fields/src/Model/FieldModel.php
- /administrator/components/com_finder/src/Indexer/Indexer.php
- /administrator/components/com_finder/src/Indexer/Query.php
- /administrator/modules/mod_menu/src/Menu/CssMenu.php
- Description: The classes in the file list require a database injected or set when used. When used in the MVC context, then they are already correctly injected, custom instantiation in extensions need to be aware about.
```php
// Old:
$indexer = new Indexer();

// New:
$indexer = new Indexer($this->getDatabase());
```

## Stringables in ajax calls are rendered directly
- PR: https://github.com/joomla/joomla-cms/pull/47945
- File: /components/com_ajax/ajax.php
- Description: When an extension returns a `Stringable` object for an ajax call, then it will be printed directly and not anymore wrapped in a `JsonResponse` object.