Repository navigation
fix: add missing keymap bindings for delete branch on github panel - #28
Merged
Merged
Conversation
The github panel context was missing CRUD keybindings (item_delete, item_create, item_edit) in all three keymap schemes (default, vim, classic). Only item_open and item_copy were bound. This meant pressing 'x' to delete a branch on the github pane did not route through the keymap dispatcher. Also fixed the branches panel to accept 'x' (standard) in addition to 'd' (legacy) for delete, and updated the help text to show 'x'. Added tests verifying dispatch for the github context and direct keypress delete on the branches panel. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
added a commit
that referenced
this pull request
May 16, 2026
Squash merge of swarm/2026-05-15 branch resolving 55 GitHub issues. Closes #4, #5, #6, #7, #8, #9, #10, #11, #12, #13, #14, #15, #16, #17, #18, #19, #20, #21, #22, #23, #24, #25, #26, #27, #28, #29, #30, #31, #32, #33, #34, #35, #36, #37, #38, #39, #40, #41, #42, #43, #44, #45, #46, #47, #48, #49, #50, #51, #52, #53, #54, #55, #56, #57, #58 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The delete branch feature (and other CRUD operations) did not work on the github panel because the keymap schemes only defined CRUD bindings for the
gitinfocontext — not thegithubcontext. Pressingxto delete a branch on the github pane bypassed the keymap dispatcher entirely, falling through to the raw key handler.Additionally, the branches panel advertised
das the delete key in its help text, but the keymap standard across all panels isx.Changes
Keymap schemes (
default.toml,vim.toml,classic.toml):n,x,e,F2,o,y) forcontext = "github", matching the existinggitinfobindings.Branches panel (
branches.go):KeyBindings()help text fromdtoxto match the keymap standard.handleKeynow accepts bothx(standard) andd(legacy) for delete.Tests:
TestGitHubPanelDeleteDispatch: verifiesxdispatchesitem_deletein thegithubcontext across all 3 schemes.TestDeleteBranch_XKeyTriggersDelete/TestDeleteBranch_DKeyTriggersDelete: verifies both keys trigger delete confirmation on the branches panel.TestCRUDBindingsExistInAllSchemesandTestCRUDContextOverridesVimSearchNextto cover thegithubcontext.Testing
go build ./...— cleango test ./... -count=1— all packages passmage install— deployed successfully