Repository navigation
fix: default confirm modal to Yes so Enter confirms actions - #27
Merged
Merged
Conversation
The ModalConfirm dialog initialized with selected=false (No), so pressing Enter on confirmation dialogs like 'Switch to branch X?' would reject the action. Users pressing Enter→Enter (select branch, then confirm) would see nothing happen because the second Enter defaulted to No. Change ModalConfirm to default selected=true (Yes), matching user expectations that Enter confirms the action shown in the dialog. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
added a commit
that referenced
this pull request
May 16, 2026
Squash merge of swarm/2026-05-15 branch resolving 55 GitHub issues. Closes #4, #5, #6, #7, #8, #9, #10, #11, #12, #13, #14, #15, #16, #17, #18, #19, #20, #21, #22, #23, #24, #25, #26, #27, #28, #29, #30, #31, #32, #33, #34, #35, #36, #37, #38, #39, #40, #41, #42, #43, #44, #45, #46, #47, #48, #49, #50, #51, #52, #53, #54, #55, #56, #57, #58 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ModalConfirm dialog initialized with selected=false (No button highlighted). When users pressed Enter on confirmation dialogs like "Switch to branch X?", the second Enter defaulted to No, silently cancelling the action.
This made branch switching (and any other confirm-dialog action) appear broken -- the dialog would flash and nothing would happen.
Fix
Changed ModalConfirm to initialize selected=true (Yes), so Enter confirms by default. This matches standard UX expectations where Enter on a confirmation dialog means "Yes".
Users can still press n, N, Esc, or arrow to No + Enter to reject.
Changes
Testing
All 100+ notify tests pass. Full suite (go test ./...) passes.