Repository navigation
fix: prevent tests from spawning real OS processes - #25
Merged
Merged
Conversation
- Use fake CLIPath in CopilotProvider test to avoid launching copilot CLI - Make startDetached a swappable var (startDetachedFn) for test injection - Rewrite platform tests to capture exec.Cmd without spawning processes - Eliminates terminal windows, error dialogs, and browser tabs during testing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
force-pushed
the
fix/test-side-effects
branch
from
March 21, 2026 15:07
110f662 to
86bebe4
Compare
jongio
added a commit
that referenced
this pull request
May 16, 2026
Squash merge of swarm/2026-05-15 branch resolving 55 GitHub issues. Closes #4, #5, #6, #7, #8, #9, #10, #11, #12, #13, #14, #15, #16, #17, #18, #19, #20, #21, #22, #23, #24, #25, #26, #27, #28, #29, #30, #31, #32, #33, #34, #35, #36, #37, #38, #39, #40, #41, #42, #43, #44, #45, #46, #47, #48, #49, #50, #51, #52, #53, #54, #55, #56, #57, #58 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
go test ./...caused real OS-level side effects on Windows:TestEnsureStarted_SetsStartedFlagusedcopilot.NewClient(nil)which launches the real Copilot CLI processTestOpenInEditor_PlatformDefaultWindowsspawnscmd /c startTestOpenInTerminal_WindowsPlatformspawnscmd /c start cmd /kTestOpenInBrowser_WindowsPlatformspawnsrundll32Fix
Copilot provider test (
internal/ai/provider_copilot_test.go)copilot.NewClient(&copilot.ClientOptions{CLIPath: "/nonexistent/copilot-cli"})so the SDK fails immediately without spawning a real processassert.Errorto verify the expected failurePlatform tests (
internal/panels/)startDetachedfrom a function to a package-levelvar startDetachedFn— standard Go pattern for test dependency injectionstartDetached(tostartDetachedFn(stubStartDetachedCapture(t)helper that captures the*exec.Cmdwithout launching itt.Cleanuprestores the original function after each testVerification
go build ./...cleango vet ./...clean