ci: bump github/codeql-action/analyze from 4.37.3 to 4.37.8 - #622
ci: bump github/codeql-action/analyze from 4.37.3 to 4.37.8#622dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [github/codeql-action/analyze](https://github.com/github/codeql-action) from 4.37.3 to 4.37.8. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@e4fba86...db488dd) --- updated-dependencies: - dependency-name: github/codeql-action/analyze dependency-version: 4.37.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
🚀 Website Preview
Preview has been cleaned up as the PR was closed. |
wbreza
left a comment
There was a problem hiding this comment.
Authentic patch bump, but it lands only one of three CodeQL pins and the Analyze job now fails on a version mismatch.
What stood out
- Supply chain — The new pin
db488dderesolves to the annotatedv4.37.8tag ingithub/codeql-action, so the SHA is authentic. - Partial bump — Only the
analyzestep moved;initandautobuildstay on the v4.37.3 commit inside the same job. - CI signal — The Analyze check already fails on this head, so the regression is observable rather than theoretical.
- Inputs and permissions —
upload: alwaysandsecurity-events: writeremain valid for v4.37.8; nothing else needs changing.
Top issues
- [F-001] CodeQL steps split across two action versions —
.github/workflows/codeql.yml:48
Cross-cutting
- [F-001] Single-step action bumps land unpaired (process) — codeql-action is three
uses:lines that must move together; nothing groups them.
Improvement opportunities
- [O-001] Pin comments omit the patch version (Optional) —
.github/workflows/codeql.yml:48
|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 | ||
| uses: github/codeql-action/analyze@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4 |
There was a problem hiding this comment.
[F-001] This bumps analyze to db488dde… (v4.37.8) but leaves the other two CodeQL steps in the same job on e4fba868… (v4.37.3):
- line 40 —
github/codeql-action/init@e4fba868… - line 45 —
github/codeql-action/autobuild@e4fba868…
The CodeQL Action requires init, autobuild, and analyze to run the same version within a job. The Analyze check on this head fails with:
Loaded a configuration file for version '4.37.3', but running version '4.37.8'
Analysis stops before SARIF upload, so this branch loses code-scanning coverage entirely rather than degrading quietly.
Fix by moving all three pins to the same commit. Lines 40 and 45 fall outside this hunk and need the same one-line edit:
uses: github/codeql-action/init@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4
uses: github/codeql-action/autobuild@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 | ||
| uses: github/codeql-action/analyze@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4 |
There was a problem hiding this comment.
[O-001] The pin carries # v4 rather than # v4.37.8. Across this repo's workflows, 84 of 88 pinned-action comments record the full semantic version — the three CodeQL pins are the exception. Recording the patch version makes the pin auditable without resolving the SHA first.
Optional and not required to merge; Dependabot tracks the dependency from the uses expression either way.
| uses: github/codeql-action/analyze@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4 | |
| uses: github/codeql-action/analyze@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8 |
|
Superseded by #623. |
Bumps github/codeql-action/analyze from 4.37.3 to 4.37.8.
Release notes
Sourced from github/codeql-action/analyze's releases.
Changelog
Sourced from github/codeql-action/analyze's changelog.
... (truncated)
Commits
db488ddMerge pull request #4102 from github/update-v4.37.8-9ee088e131845f5bUpdate changelog for v4.37.89ee088eMerge pull request #4080 from github/henrymercer/studious-giggle1aef003Address review feedback on overlay disk flags508b83bMerge main into overlay minimum disk feature branchd97b342Merge pull request #4098 from github/mbg/permission-error-as-configuration-error47fa622MakeEACCESaConfigurationError45693ccRefactorENOSPCcheck intoisDiskConfigurationErrorfunctionc2fd8f5Merge pull request #4081 from github/mario-campos/version-cache-to-diskc56f48eLog unexpected conditions during caching CLI outputDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)