ci: bump github/codeql-action/autobuild from 4.37.3 to 4.37.8 - #621
ci: bump github/codeql-action/autobuild from 4.37.3 to 4.37.8#621dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [github/codeql-action/autobuild](https://github.com/github/codeql-action) from 4.37.3 to 4.37.8. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@e4fba86...db488dd) --- updated-dependencies: - dependency-name: github/codeql-action/autobuild dependency-version: 4.37.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
🚀 Website Preview
Preview has been cleaned up as the PR was closed. |
wbreza
left a comment
There was a problem hiding this comment.
The bump is authentic, but merging it alone breaks CodeQL scanning on main — all three codeql-action pins must move together.
What stood out
- Supply chain checks out —
db488ddeis the genuine v4.37.8 tag on github/codeql-action, 204 commits ahead of the previous pin with nothing behind, and no advisory affects the 4.37.3–4.37.8 range. - Version lock-step is enforced at runtime — the action rejects a config written by a different version, so init, autobuild, and analyze cannot sit at different pins.
- The blast radius is the security scan itself — Autobuild aborts before analysis, so Go code goes unscanned rather than a check merely turning red.
Top issues
- [F-001] Merging this alone breaks CodeQL scanning on main —
.github/workflows/codeql.yml:45 - [F-002] Ungrouped updates split the codeql-action pins across three PRs —
.github/workflows/codeql.yml:48
Cross-cutting
- [F-002] Ungrouped updates split the codeql-action pins across three PRs (process) — Each release round yields three PRs that individually fail CI and cannot be merged in isolation.
Improvement opportunities
- [O-001] Version comment reads
# v4where this repo records full versions (Optional) —.github/workflows/codeql.yml:45
|
|
||
| - name: Autobuild | ||
| uses: github/codeql-action/autobuild@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 | ||
| uses: github/codeql-action/autobuild@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4 |
There was a problem hiding this comment.
[F-001] Merging this bump on its own leaves CodeQL scanning broken on the default branch.
The init step (line 40) and the analyze step (line 48) stay pinned to e4fba868... (v4.37.3) while this line moves autobuild to db488dde... (v4.37.8). The CodeQL Action validates that the config file written by init was produced by the same version as the step consuming it, and throws when it was not — src/config-utils.ts:
if (config.version !== getActionVersion()) {
throw new ConfigurationError(
`Loaded a configuration file for version '${config.version}', but running version '${getActionVersion()}'`,
);
}
The Analyze check on this PR fails for exactly that reason:
##[error]We were unable to automatically build your code. Please replace the call to the autobuild action with your custom build steps.
Loaded a configuration file for version '4.37.3', but running version '4.37.8'
The scheduled run on main, where all three steps sit at matching v4.37.3, passes — so the breakage originates here rather than being pre-existing or environmental. It is also not a token-permission artifact of a bot-authored PR: the failure occurs inside Autobuild, well before any SARIF upload.
Because Autobuild aborts before analysis runs, the consequence is not a merely red check — Go code stops being scanned on main until the pins are realigned.
Land all three github/codeql-action/* pins on db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 in a single commit instead of merging this path in isolation. Lines 40 and 48 are outside this diff hunk, so they cannot be carried as suggestions here.
| uses: github/codeql-action/autobuild@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4 | ||
|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 |
There was a problem hiding this comment.
[F-002] Dependabot has no groups rule for github/codeql-action/*, so each release round produces three PRs that are mutually breaking.
This line still pins analyze to v4.37.3 because init, autobuild, and analyze are tracked as independent dependencies and each receives its own PR. Given that the three steps must execute at the same version, no single PR in the set can pass CI, and none is safe to merge alone. The pattern has already repeated: the init, autobuild, and analyze PRs from this round all fail with the same version-mismatch error, as did the preceding v4.37.7 round.
.github/dependabot.yml declares the github-actions ecosystem with no grouping. Adding a group preserves commit-level pinning while collapsing the three updates into one PR that is coherent on arrival:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
commit-message:
prefix: "ci"
groups:
codeql-action:
patterns:
- "github/codeql-action/*"
Moving the three steps to the floating @v4 tag would also eliminate the mismatch, but it surrenders commit-level provenance on the security-scanning workflow itself and is the weaker trade.
|
|
||
| - name: Autobuild | ||
| uses: github/codeql-action/autobuild@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 | ||
| uses: github/codeql-action/autobuild@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4 |
There was a problem hiding this comment.
[O-001] 💡 Improvement Opportunity (optional — not required to merge)
Benefit: The trailing comment reads # v4 while the pin resolves to v4.37.8. The rest of this repo annotates pinned actions with the full version — actions/checkout ... # v7.0.1, actions/setup-go ... # v7.0.0 — 84 full-version comments against 4 major-only, all four of the latter being these codeql-action steps. Recording the full version makes a divergence between lines 40, 45, and 48 legible on inspection instead of concealing it behind three identical # v4 comments.
Effort: One comment per pinned codeql-action step.
Optionality: Optional
Sketch:
| uses: github/codeql-action/autobuild@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4 | |
| uses: github/codeql-action/autobuild@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8 |
|
Superseded by #626. |
Bumps github/codeql-action/autobuild from 4.37.3 to 4.37.8.
Release notes
Sourced from github/codeql-action/autobuild's releases.
Changelog
Sourced from github/codeql-action/autobuild's changelog.
... (truncated)
Commits
db488ddMerge pull request #4102 from github/update-v4.37.8-9ee088e131845f5bUpdate changelog for v4.37.89ee088eMerge pull request #4080 from github/henrymercer/studious-giggle1aef003Address review feedback on overlay disk flags508b83bMerge main into overlay minimum disk feature branchd97b342Merge pull request #4098 from github/mbg/permission-error-as-configuration-error47fa622MakeEACCESaConfigurationError45693ccRefactorENOSPCcheck intoisDiskConfigurationErrorfunctionc2fd8f5Merge pull request #4081 from github/mario-campos/version-cache-to-diskc56f48eLog unexpected conditions during caching CLI outputDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)