-
Notifications
You must be signed in to change notification settings - Fork 6
ci: bump github/codeql-action/init from 4.37.3 to 4.37.8 #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,7 +37,7 @@ jobs: | |
| cache-dependency-path: cli/go.sum | ||
|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 | ||
| uses: github/codeql-action/init@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [F-002] Dependabot split this upgrade across three PRs, one per action path:
Because the three steps must share a version, merging any subset leaves Fix: merge all three in one batch, or fold the autobuild and analyze pins into this PR and close #621 and #622 as superseded.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [F-003] The trailing comment records
The imprecise comment predates this PR on the CodeQL steps, so this is carried forward rather than introduced, but it hides which release was actually audited and makes the skew in F-001 invisible to a reader scanning the file. Recording |
||
| with: | ||
| languages: go | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F-001] This bump moves
inittodb488ddef3bf6cb639b32c2e9a7c0a7ea8271d28(v4.37.8), butautobuild(line 45) andanalyze(line 48) remain pinned toe4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81(v4.37.3). CodeQL requires every step in the job to run the same version, and the mismatch is a hard failure, not a warning.The
Analyzecheck on this PR fails at the Autobuild step:Analysis aborts before any SARIF is uploaded, so the branch gets no CodeQL results at all. The last 10 CodeQL runs on
mainall succeeded with the three steps aligned at 4.37.3, which confirms the skew is introduced here rather than pre-existing.Fix: repoint all three CodeQL steps to
db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28in a single change.