Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
languages: go

- name: Autobuild
uses: github/codeql-action/autobuild@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4
uses: github/codeql-action/autobuild@5595ccaf912efad79be6eef63a5619ff05969be3 # v4

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F-001] This bumps autobuild to 4.37.6 while init (line 40) and analyze (line 48) stay pinned to e4fba868… (4.37.3). init stamps the saved CodeQL config with its own action version, and autobuild rejects a config whose version differs from its own, so the job dies before analysis runs.

The CodeQL run on this head SHA failed at the Autobuild step:

Loaded a configuration file for version '4.37.3', but running version '4.37.6'

with the annotation:

Not all workflow steps that use github/codeql-action actions use the same version.

Companion PRs #604 (init) and #605 (analyze) bump the same 4.37.3 → 4.37.6. No merge order of the three avoids a broken window — whichever lands first leaves main with a failing CodeQL Analyze job. Land all three pins together, or fold the other two lines into this branch:

-        uses: github/codeql-action/init@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4
+        uses: github/codeql-action/init@5595ccaf912efad79be6eef63a5619ff05969be3 # v4
-        uses: github/codeql-action/analyze@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4
+        uses: github/codeql-action/analyze@5595ccaf912efad79be6eef63a5619ff05969be3 # v4

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[O-001] The trailing pin comment reads # v4, but every other pinned action in this repo's workflows carries a full semver comment (for example actions/checkout@… # v7.0.1 in ci.yml). The three codeql-action lines are the only bare-major exceptions, so the file alone never reveals that this is 4.37.6. Tightening the comment restores the audit trail, and is worth applying to all three lines once the sub-actions are aligned.

Suggested change
uses: github/codeql-action/autobuild@5595ccaf912efad79be6eef63a5619ff05969be3 # v4
uses: github/codeql-action/autobuild@5595ccaf912efad79be6eef63a5619ff05969be3 # v4.37.6


- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4
Expand Down
Loading