ci: bump github/codeql-action/analyze from 4.37.3 to 4.37.6 - #605
ci: bump github/codeql-action/analyze from 4.37.3 to 4.37.6#605dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [github/codeql-action/analyze](https://github.com/github/codeql-action) from 4.37.3 to 4.37.6. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@e4fba86...5595cca) --- updated-dependencies: - dependency-name: github/codeql-action/analyze dependency-version: 4.37.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
🚀 Website Preview
Preview has been cleaned up as the PR was closed. |
wbreza
left a comment
There was a problem hiding this comment.
Clean, correctly pinned bump — but merging it alone leaves CodeQL on mismatched versions and the Analyze job fails.
What stood out
- Provenance verified — 5595ccaf912efad79be6eef63a5619ff05969be3 is exactly the v4.37.6 tag on github/codeql-action, and the SHA-pinned convention is preserved.
- No analyze contract change — the v4.37.4–v4.37.6 changes are init-scoped (remote config path, bundle download fallback, tools repository property); upload: always remains valid.
- Intra-job version skew — init and autobuild stay at v4.37.3 while analyze moves to v4.37.6, and the action's version-consistency guard rejects that combination.
Top issues
- [F-001] Mixed codeql-action versions abort the Analyze job — .github/workflows/codeql.yml:48
Cross-cutting
- [F-001] codeql-action pins must move as one set (process) — three separate PRs bump init, autobuild and analyze; any partial landing leaves main mismatched.
Improvement opportunities
- [O-001] Group github/codeql-action bumps in dependabot.yml (Recommended) — .github/workflows/codeql.yml:48
|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 | ||
| uses: github/codeql-action/analyze@5595ccaf912efad79be6eef63a5619ff05969be3 # v4 |
There was a problem hiding this comment.
[F-001] Only analyze moves to v4.37.6 here — init (line 40) and autobuild (line 45) stay pinned at e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 (v4.37.3). The CodeQL Action enforces version consistency across all github/codeql-action/* steps in a job, and the Analyze job on this PR fails at Perform CodeQL Analysis:
CODEQL_ACTION_VERSION: 4.37.3
##[error]Loaded a configuration file for version '4.37.3', but running version '4.37.6'
init and autobuild succeed; only the analyze step and its post-action fail, and recent Analyze runs on main pass — so the failure is introduced by this change, not pre-existing. Analysis aborts before SARIF upload, so upload: always on line 50 cannot preserve the scan results.
Landing this on its own puts main in the mismatched state for every push, pull request, and the weekly schedule until #604 (init) and #607 (autobuild) also land. Move all three pins to 5595ccaf912efad79be6eef63a5619ff05969be3 in one change, or hold this until the other two merge in the same batch.
|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 | ||
| uses: github/codeql-action/analyze@5595ccaf912efad79be6eef63a5619ff05969be3 # v4 |
There was a problem hiding this comment.
[F-002] All three github/codeql-action steps carry the same # v4 trailing comment, but after this change lines 40 and 45 are v4.37.3 while line 48 is v4.37.6. Other actions in this workflow record the patch level (actions/checkout … # v7.0.1, actions/setup-go … # v7.0.0), so codeql-action is the one place where a reader cannot see that the pins have drifted apart.
| uses: github/codeql-action/analyze@5595ccaf912efad79be6eef63a5619ff05969be3 # v4 | |
| uses: github/codeql-action/analyze@5595ccaf912efad79be6eef63a5619ff05969be3 # v4.37.6 |
|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 | ||
| uses: github/codeql-action/analyze@5595ccaf912efad79be6eef63a5619ff05969be3 # v4 |
There was a problem hiding this comment.
[O-001] .github/dependabot.yml has no groups: entry for the github-actions ecosystem, so Dependabot files init, autobuild and analyze as three independent PRs (#604, #605, #607). Because CodeQL requires one version across the job, none of the three passes CI on its own and every codeql-action release reproduces this. Grouping them makes the bump atomic:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
commit-message:
prefix: "ci"
groups:
codeql-action:
patterns:
- "github/codeql-action*"|
Superseded by #618. |
Bumps github/codeql-action/analyze from 4.37.3 to 4.37.6.
Release notes
Sourced from github/codeql-action/analyze's releases.
Changelog
Sourced from github/codeql-action/analyze's changelog.
... (truncated)
Commits
5595ccaMerge pull request #4071 from github/update-v4.37.6-6a9359a1bec9c757Add change note for PR 407045c8742Update changelog for v4.37.66a9359aMerge pull request #4070 from github/mbg/remote-address/change-file-default065cdc0ChangeDEFAULT_CONFIG_FILE_NAMEf99dd5aMerge pull request #4066 from github/dependabot/npm_and_yarn/js-yaml-5.2.21804b21Merge pull request #4068 from github/mergeback/v4.37.5-to-main-d1ba80a13020a2fRebuild93c3a5aUpdate changelog and version after v4.37.5d1ba80aMerge pull request #4067 from github/update-v4.37.5-1cd4d01d5Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)