Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
cache-dependency-path: cli/go.sum

- name: Initialize CodeQL
uses: github/codeql-action/init@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4
uses: github/codeql-action/init@5595ccaf912efad79be6eef63a5619ff05969be3 # v4

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F-001] This bump moves init to v4.37.6, but autobuild (line 45) and analyze (line 48) in this same workflow still point at e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 (v4.37.3).

init stamps its own version into the config it writes to RUNNER_TEMP, and the sibling steps enforce strict equality on that value — any difference, including a same-major patch delta, hard-errors rather than warning.

The Analyze check on this head SHA (90053ea) already completed with conclusion: failure:

##[error]We were unable to automatically build your code. Please replace the call to the autobuild action with your custom build steps. Loaded a configuration file for version '4.37.6', but running version '4.37.3'

Merging this PR on its own takes the CodeQL security scan down on main. Land it together with #605 (analyze) and #607 (autobuild) so all three sub-actions reach 5595ccaf912efad79be6eef63a5619ff05969be3 at once.

The pin itself is correct — 5595ccaf912efad79be6eef63a5619ff05969be3 dereferences exactly to the v4.37.6 annotated tag. The only defect is the co-merge requirement.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[O-001] (Recommended — optional, not required to merge)

Dependabot tracks each uses: path as a separate dependency, so init, autobuild, and analyze arrive as three independent PRs (#604, #607, #605). Whichever lands first leaves the workflow in a mismatched, failing state — which is what happened here.

A group rule in .github/dependabot.yml makes all three arrive in a single PR and prevents the split from recurring:

groups:
  codeql-action:
    patterns:
      - "github/codeql-action*"

While editing those lines, the three CodeQL pins carry major-only # v4 comments, whereas 82 of the 86 action pins elsewhere in this repo record the precise version (for example # v7.0.1 in ci.yml). Tightening them to # v4.37.6 would match the dominant convention.

with:
languages: go

Expand Down
Loading