Skip to content

Flag in-source fragments and re-inject for quantification (--flag_in_source)#3

Open
jonasscheid wants to merge 5 commits into
devfrom
flag-in-source-fragments
Open

Flag in-source fragments and re-inject for quantification (--flag_in_source)#3
jonasscheid wants to merge 5 commits into
devfrom
flag-in-source-fragments

Conversation

@jonasscheid

Copy link
Copy Markdown
Owner

Description

Adds --flag_in_source (default false). After rescoring, flags in-source fragments among the 100% FDR PSMs using the FDR-filtered peptides as parents (strict per-run co-elution in observed RT + DeepLC RT-prediction mismatch), tags every PeptideHit with an is_isf UserParam, and re-injects the flagged fragments into the FDR-filtered set so their signal reaches quantification. is_isf is exported to the final TSV.

New module PYOPENMS_FLAGINSOURCE (bin/flag_in_source_fragments.py); when the flag is off, behaviour is unchanged.

Depends on nf-core#460 (QUANT groupKey combine fix) for end-to-end quantification.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • CHANGELOG.md is updated.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.

jonasscheid and others added 2 commits June 9, 2026 07:21
…them into quantification

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f514bdc

+| ✅ 323 tests passed       |+
#| ❔   1 tests had warnings |#
!| ❗   6 tests had warnings |!
Details

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • nextflow_config - Config manifest.version should end in dev: 3.2.0
  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here
  • schema_lint - Input mimetype is missing or empty

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-06-10 12:56:22

jonasscheid and others added 3 commits June 9, 2026 12:42
…lagging, snapshot versions in test, honor --min-len

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…g survives the QUANT consensus into the final TSV

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant