Skip to content

Idea : export the round ID when possible #941

Description

@TwilCynder

Round name display has always been an issue, between localization and people just generally having different ways to call each round beyond Winner semis / loser quarters. This has led me to make multiple overlays that straight up have a hard-coded table with the names I want for each round, which is probably the best solution but would be made way easier if the program state contained the numerical ID of the round.

There are 2 ways to achieve this :

  • simple way, we simply take the round ID from the start.gg request and export it. Unfortunately it means having an information that's controlled exclusively by the data provider again, with no control through the GUI, like seeds used to be. We don't really want that, but again it's the simpler solution
  • more difficult : the premade round names that TSH already has (that appear in the dropdown) are each tied to a round ID, selecting one exports the corresponding round ID, BUT if the user types an arbitrary string into the input, no round ID is exported (overlays that rely on round ID should in turn do something like "if there is a round ID in the state, I use that to display one of my hard-coded round names, if there is not I use the round name text from the state directly").

This is pretty much a reminder to myself to do this when I have more time, but if someone wants to look into this ...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions