Skip to content

Use MultiXML constant to fix deprecation warning from multi_xml 0.9+ #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robzolkos wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

Use MultiXML constant to fix deprecation warning from multi_xml 0.9+ #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/httparty/parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def parse

def xml
require 'multi_xml'
MultiXml.parse(body)
(defined?(MultiXML) ? MultiXML : MultiXml).parse(body)
end

UTF8_BOM = "\xEF\xBB\xBF"
Expand Down
5 changes: 3 additions & 2 deletions spec/httparty/parser_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,9 @@ def self.name
HTTParty::Parser.new('body', nil)
end

it "parses xml with MultiXml" do
expect(MultiXml).to receive(:parse).with('body')
it "parses xml with MultiXML" do
xml_parser = defined?(MultiXML) ? MultiXML : MultiXml
expect(xml_parser).to receive(:parse).with('body')
subject.send(:xml)
end

Expand Down