Fix boolean return bugs fixes #170 #123 #138#183
Open
aploese wants to merge 5 commits intojnr:masterfrom
Open
Conversation
Member
|
Another one that got left behind, my apologies. This no longer merges, but if you are out there maybe you can help update it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK the extended Boolean Tests run on Debian x86_64, x86_32 and armhf.
General 0 is false any other value will be true.
fixed for X86_64StubCompiler and Java DefaultStubCompiler the Java boolean is a stored in 8bit so any bit set above the 7th is ignored - this is fixed in the generated bytecode (NumberUtils).
This could be done also in the X86_64StubCompiler.compile(...) in the switch statement:
"switch (resultType.getNativeType()) {"
#170 is serious, arm cant load the correct lib later on.
The error message is quit funny - you will never guess what was really the cause. Try to remove the dependency to com.github.jnr:jffi:1.2.16:native. This is to be fixed in jffi.
.