Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Radio and Checkbox form elements#140

Open
codebytimlong wants to merge 7 commits into
refactor/frontfrom
refactor/form/add-checkbox-element
Open

Radio and Checkbox form elements#140
codebytimlong wants to merge 7 commits into
refactor/frontfrom
refactor/form/add-checkbox-element

Conversation

@codebytimlong
Copy link
Copy Markdown
Collaborator

This PR Includes components to add refactored inputs and checkboxes to basestack.

I started using a pattern inspired from laravel, with x-components (x-checkbox, x-radio, x-fieldset). I think it may be worth using an x-component pattern on global components. I've gone back and forth on the idea so maybe we should discuss it but components like button, textarea, input, label that have a HTML tag of the same name, I like having a simple name and a simple indication that this is a component.

Also in this PR:

  • Installed tailwindcss forms plugin
  • new Checkbox and Radio components with stories for each
  • new Fieldset component with story

@codebytimlong codebytimlong requested a review from ahansrisuk June 2, 2022 16:15
@codebytimlong codebytimlong self-assigned this Jun 2, 2022
@ahansrisuk
Copy link
Copy Markdown
Collaborator

Overall looks good. The styling on these components looks great, I did not know Tailwind had a forms plugin.

I would just verify the data in the form is correct, otherwise it's good to go!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants