This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Radio and Checkbox form elements#140
Open
codebytimlong wants to merge 7 commits into
Open
Conversation
added 7 commits
May 19, 2022 14:18
Collaborator
|
Overall looks good. The styling on these components looks great, I did not know Tailwind had a forms plugin. I would just verify the data in the form is correct, otherwise it's good to go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Includes components to add refactored inputs and checkboxes to basestack.
I started using a pattern inspired from laravel, with
x-components(x-checkbox,x-radio,x-fieldset). I think it may be worth using an x-component pattern on global components. I've gone back and forth on the idea so maybe we should discuss it but components likebutton,textarea,input,labelthat have a HTML tag of the same name, I like having a simple name and a simple indication that this is a component.Also in this PR:
formspluginCheckboxandRadiocomponents with stories for eachFieldsetcomponent with story