Open
Conversation
Author
|
@naveenku-jfrog can you also please take a look here? Our TSM is Douglas Hemsworth. Thanks! |
Contributor
Collaborator
|
Static Analysis Tests are failing. Please fix these tests first. |
Author
|
thanks for taking the time to review, did you see what I wrote in the pr message?
this needs the jfrog-cli-core changes to work |
this allows scripting the login without the modal prompt
tim-goto
force-pushed
the
feature/tharing/server-id-for-login-command
branch
from
c219c88 to
836859f
Compare
Author
|
thank you for reviewing this pr, I also added tests for my added lines. Again, this needs the jfrog-cli-core pr to be merged first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows scripting the login without the modal prompt
merge after jfrog/jfrog-cli-core#1529
masterbranch.go vet ./....go fmt ./....