Return errors for undelivered HID reports - #1554
Draft
BenDManning wants to merge 4 commits into
Draft
Conversation
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1516 so its recovery work stays the starting point. This is not a competing PR to
dev.The additional contract needed by BenDManning/jetkvm-mcp#146 is synchronous: a report may only be acknowledged after its HID endpoint accepts the complete write. Later recovery cannot turn an already dropped report into success.
Changes:
configuredbefore attempting keyboard, absolute mouse, relative mouse, or wheel reports;Tests deterministically fill a pipe to stall each endpoint and verify the first report returns
os.ErrDeadlineExceeded. Companion cases read the exact bytes for every successful/acknowledged report. The common RPC/gadget seam verifies rejection for every non-configured USB state and exact write-error propagation.Local checks:
GOMODCACHE=/tmp/jetkvm-kvm-146-gomod GOCACHE=/tmp/jetkvm-kvm-146-gocache go test -race ./internal/usbgadget -count=1GOMODCACHE=/tmp/jetkvm-kvm-146-gomod GOCACHE=/tmp/jetkvm-kvm-146-gocache go vet ./internal/usbgadgetgit diff --checkIndependent review at exact head
2408a67f23a69f04c2758588f01ee836bf7222fb:Upstream checks at that exact head:
No firmware was installed or flashed, and no device mutation occurred.