Skip to content

fix(serial): recover ATX/DC extension workers from transient read errors #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilyongnoh-ux wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(serial): recover ATX/DC extension workers from transient read errors #1525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 46 additions & 8 deletions serial.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var consoleBroker *ConsoleBroker

func mountATXControl() error {
_ = port.SetMode(defaultMode)
go runATXControl()
go runATXControl(port)

return nil
}
Expand All @@ -40,16 +40,35 @@ var (
btnPWRState bool
)

func runATXControl() {
func runATXControl(p serial.Port) {
scopedLogger := serialLogger.With().Str("service", "atx_control").Logger()

reader := bufio.NewReader(port)
reader := bufio.NewReader(p)
backoff := time.Second
const maxBackoff = 30 * time.Second
for {
line, err := reader.ReadString('\n')
if err != nil {
// If the global port has been swapped out (unmount or extension
// switch replaces it via reopenSerialPort), the read error is an
// intentional shutdown signal for this worker: stop quietly.
if port != p {

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Synchronize port replacement detection

When an extension is unmounted or switched, reopenSerialPort writes the package-level port while the control goroutine can reach this comparison immediately after Close unblocks ReadString; concurrently reading and writing an interface value is a Go data race and can produce race-detector failures or, in rare cases, observe a torn interface value. The same pattern appears in runDCControl, so the replacement signal should use synchronized state or an explicit shutdown channel rather than reading port directly from the worker.

Useful? React with 👍 / 👎.

scopedLogger.Debug().Msg("Serial port replaced, stopping ATX control worker")
return
}
// Otherwise the read failed transiently. Back off and retry with a
// fresh reader instead of terminating the goroutine permanently.
scopedLogger.Warn().Err(err).Msg("Error reading from serial port")
return
time.Sleep(backoff)
backoff *= 2
if backoff > maxBackoff {
backoff = maxBackoff
}
reader = bufio.NewReader(p)
continue
}
// Successful read: reset the backoff.
backoff = time.Second

// Each line should be 4 binary digits + newline
if len(line) != 5 {
Expand Down Expand Up @@ -141,7 +160,7 @@ func pressATXResetButton(duration time.Duration) error {
func mountDCControl() error {
_ = port.SetMode(defaultMode)
registerDCMetrics()
go runDCControl()
go runDCControl(port)
return nil
}

Expand All @@ -161,16 +180,35 @@ func getDCState() DCPowerState {
return dcState
}

func runDCControl() {
func runDCControl(p serial.Port) {
scopedLogger := serialLogger.With().Str("service", "dc_control").Logger()
reader := bufio.NewReader(port)
reader := bufio.NewReader(p)
hasRestoreFeature := false
backoff := time.Second
const maxBackoff = 30 * time.Second
for {
line, err := reader.ReadString('\n')
if err != nil {
// If the global port has been swapped out (unmount or extension
// switch replaces it via reopenSerialPort), the read error is an
// intentional shutdown signal for this worker: stop quietly.
if port != p {
scopedLogger.Debug().Msg("Serial port replaced, stopping DC control worker")
return
}
// Otherwise the read failed transiently. Back off and retry with a
// fresh reader instead of terminating the goroutine permanently.
scopedLogger.Warn().Err(err).Msg("Error reading from serial port")
return
time.Sleep(backoff)
backoff *= 2
if backoff > maxBackoff {
backoff = maxBackoff
}
reader = bufio.NewReader(p)
continue
}
// Successful read: reset the backoff.
backoff = time.Second

// Split the line by semicolon
parts := strings.Split(strings.TrimSpace(line), ";")
Expand Down
Loading