Fixed incompatibility with Mobile-Detect v2.8.43#209
Open
sunnydavis wants to merge 1 commit intojenssegers:masterfrom
Open
Fixed incompatibility with Mobile-Detect v2.8.43#209sunnydavis wants to merge 1 commit intojenssegers:masterfrom
sunnydavis wants to merge 1 commit intojenssegers:masterfrom
Conversation
haitamkh
approved these changes
Nov 3, 2023
|
No longer needed, see #208 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is caused by the ->is*() function, aka the "Extended" features confusing the core function of detecting mobile devices. I think the better way to fix it is to overwrite the getMobileDetectionRules() and make sure it won't be polluted. In this case the extended features still work while not sacrifice the ability to detect mobile devices.