Migrate from Commons Lang 2 to Commons Lang 3 - #858
Merged
Conversation
c00ler
approved these changes
Aug 3, 2026
Member
|
Thanks for merging it, would it be possible to release it please? Jenkins will soon be removing this library and need plugins that depend on it to be released first. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from deprecated/EOL Commons Lang 2 to Commons Lang 3. This repository was previously using
an inconsistent mix of versions —
commons-lang3-apiwas already declared, whileGradle.javastill imported
org.apache.commons.lang.StringUtils.Part of the effort to remove Commons Lang 2 from Jenkins core — jenkinsci/jenkins#16404,
jenkinsci/jenkins#26105. Commons Lang 2 is EOL and carries an unfixed advisory
(GHSA-j288-q9x7-2f5v).
What's changed
Gradle.java:org.apache.commons.lang.StringUtilsbecomesorg.apache.commons.lang3.StringUtils.Import-only;
isBlank/isNotBlankare identical in Lang 3 andcommons-lang3-apiis already declared.6.2211.v27f680c93c53so theban-commons-lang-2enforcer rule isavailable, and enabled it.
Testing done
mvn -B -ntp -pl plugin -am clean verifyon Java 21 / macOS: the unit tests pass. The run thenhangs in
GradlePluginIntegrationTestinsideGradleInstallation.forNode, downloading a Gradledistribution — unrelated to this change, so I left it to CI.
The
ban-commons-lang-2enforcer rule is enabled in this PR, so the build fails if anorg.apache.commons.lang.*import comes back.Submitter checklist
🤖 This pull request was generated with AI assistance (Claude Code) as part of a bulk migration
across Jenkins plugins. If anything here looks wrong, please comment on this PR or contact @timja.