Repository navigation
test: spacing-utilities regression for issue #61 - #176
Merged
Merged
Conversation
- New fixture: test/spacing-utilities.html with data-test-id locators - New spec: test/vrt/validations/spacing-utilities.spec.js (9 assertions) - Extends yarn test:vrt to include the new spec - Validates .is-marginless and .is-paddingless on .container, .row, .col - All 28 VRT tests pass (19 existing + 9 new) Base SHA: 32e0c7e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation-only regression test preserving the resolved spacing utilities from
issue #61 as a permanent Chromium VRT-suite check.
Changed files
test/spacing-utilities.html— minimal fixture withdata-test-idlocators, no display-only JStest/vrt/validations/spacing-utilities.spec.js— 9 computed-style assertionspackage.json— extendedtest:vrtscript (one path addition)Assertions
.container.is-marginless.is-paddingless.row.is-marginless.col.is-marginless.col-6.is-marginlessValidation
Environment
Disposition
Close #136 — the spacing utilities from #61 are already implemented and
documented. This PR adds regression coverage to prevent future regressions.