Repository navigation
fix(vrt): normalize snapshot layout and platform policy - #175
Merged
Merged
Conversation
Remove 11 stale/unreferenced snapshot files, document platform policy
in README. No CSS/config changes.
Stale files (no platform suffix or orphaned root-level):
- 6 unsuffixed *-chromium.png (index, components)
- 3 stale platform-duplicates (grouped-controls subdirectory)
- 4 orphaned root-level grouped-controls artifacts
Active baselines preserved: 36 files (35 VRT + 1 artifact-only).
Proven via Playwright failure output: toMatchSnapshot('<arg>') resolves
to test/vrt/snapshots/<spec>-snapshots/<arg>-chromium-<platform>.png
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Normalize Chromium VRT snapshot layout and document platform policy.
Problem
Mixed snapshot conventions across the repository:
*-chromium.pngfiles (no platform suffix, never resolved by any execution path)Changes
test/vrt/README.md: added snapshot layout and platform policy section documenting:toMatchSnapshotarguments to platform-specific pathspage.screenshot({ path })files)Evidence
yarn test:vrt— 19 passed (11.2s)yarn test(stylelint) — PASSgit diff --check— PASS (no whitespace errors)test/vrt/snapshot-mapping-173.md(untracked, for review)Impact