Repository navigation
fix(vrt): clean up duplicate nav logo baselines - #174
Merged
Merged
Conversation
…lines - Remove snapshotIdFormat from playwright.config.js (unsupported, ignored) - Delete root-level stale snapshots (pre-move location, never resolved) - Delete 11 generic (no-suffix) PNGs from validations dir (not platform-resolved) - Retain 22 platform-specific baselines (chromium-darwin + chromium-linux) Changed: 1 modified, 22 deleted, 0 added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Repair the incomplete merge of PR #169 / fix/167-follow-up by removing unsupported
snapshotIdFormatconfiguration and stale pre-move snapshots.Context
PR #169 committed snapshots to both a stale root-level directory and a platform-suffixed validations directory. The
snapshotIdFormatconfig line is silently ignored by Playwright 1.62.0, so only the validated directory's platform-specific baselines are resolved.Changes
snapshotIdFormatfromplaywright.config.js(unsupported, ignored)*-chromium-darwin.png+ 11*-chromium-linux.png)Validation
yarn test:vrt— 19/19 passed (9.7s)git diff --check— no whitespace errorsFiles changed
playwright.config.js(1 line removed) + 22 PNG deletions = 23 files changed, 1 deletion, 0 additions