Preserve quoted trailing whitespace in config values#2145
Merged
jelmer merged 1 commit intojelmer:mainfrom Apr 20, 2026
Merged
Conversation
jelmer
approved these changes
Apr 20, 2026
Owner
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2144.
The initial Hypothesis config round-trip property exposed a case where quoted trailing whitespace was not preserved when reading config values back.
For example, a value like
b" "is written as a quoted config value, but parsing discarded the whitespace because_parse_stringbuffered whitespace even while inside quotes.This changes
_parse_stringso spaces and tabs inside quotes are preserved immediately, while trailing whitespace outside quotes is still ignored.Also included: