refactor(desktop/js): replace var with const/let in scenario and timeline#3321
Open
limad wants to merge 1 commit into
Open
refactor(desktop/js): replace var with const/let in scenario and timeline#3321limad wants to merge 1 commit into
limad wants to merge 1 commit into
Conversation
…line Modules: scenario, timeline - Replace all `var` declarations with `const` (not reassigned) or `let` (reassigned) - Convert `for (var x in ...)` to `for (const x in ...)` - Convert `for (var i = 0; ...)` to `for (let i = 0; ...)` No functional changes. Bug fixes for scenario.js are tracked separately in PR jeedom#3319.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
varwithconst/letin the scenario and timeline desktop/js modules.Modules: scenario, timeline
Changes
vardeclarations →const(not reassigned) orlet(reassigned)for (var x in/of ...)→for (const x in/of ...)for (var i = 0; ...)→for (let i = 0; ...)No functional changes. Bug fixes for scenario.js are tracked separately in #3319 (Lot 2).
Type of change
Suggested changelog entry
Test plan
Known risks