Skip to content

Refactor var to const/let in admin/system + log search multi-term (4/4) #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mips2648 merged 2 commits into from
May 6, 2026
Merged

Refactor var to const/let in admin/system + log search multi-term (4/4) #3303

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a9a79b
Refactor var to const/let in admin/system files + log search refactor
limad Apr 28, 2026
485211e
Revert log search to single-term (Salvialf/Mips2648 review)
limad May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/js/appMobile.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jeedom.appMobile.detected = function() {
}

jeedom.appMobile.postToApp = function (_action, _options = {}) {
let message = {}
const message = {}
if (window.ReactNativeWebView != undefined) {
message.action = _action
message.options = _options
Expand Down
48 changes: 24 additions & 24 deletions core/js/backup.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@
jeedom.backup = function() {};

jeedom.backup.backup = function(_params) {
var paramsRequired = [];
var paramsSpecifics = {};
const paramsRequired = [];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/jeedom.ajax.php';
paramsAJAX.data = {
action: 'backup',
Expand All @@ -35,16 +35,16 @@ jeedom.backup.backup = function(_params) {
}

jeedom.backup.restoreLocal = function(_params) {
var paramsRequired = [];
var paramsSpecifics = {};
const paramsRequired = [];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/jeedom.ajax.php';
paramsAJAX.data = {
action: 'restore',
Expand All @@ -54,16 +54,16 @@ jeedom.backup.restoreLocal = function(_params) {
}

jeedom.backup.remove = function(_params) {
var paramsRequired = ['backup'];
var paramsSpecifics = {};
const paramsRequired = ['backup'];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/jeedom.ajax.php';
paramsAJAX.data = {
action: 'removeBackup',
Expand All @@ -73,16 +73,16 @@ jeedom.backup.remove = function(_params) {
}

jeedom.backup.uploadCloud = function(_params) {
var paramsRequired = ['backup'];
var paramsSpecifics = {};
const paramsRequired = ['backup'];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/repo.ajax.php';
paramsAJAX.data = {
action: 'uploadCloud',
Expand All @@ -92,16 +92,16 @@ jeedom.backup.uploadCloud = function(_params) {
}

jeedom.backup.restoreCloud = function(_params) {
var paramsRequired = ['backup', 'repo'];
var paramsSpecifics = {};
const paramsRequired = ['backup', 'repo'];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/repo.ajax.php';
paramsAJAX.data = {
action: 'restoreCloud',
Expand All @@ -112,16 +112,16 @@ jeedom.backup.restoreCloud = function(_params) {
}

jeedom.backup.list = function(_params) {
var paramsRequired = [];
var paramsSpecifics = {};
const paramsRequired = [];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/jeedom.ajax.php';
paramsAJAX.data = {
action: 'listBackup',
Expand Down
36 changes: 18 additions & 18 deletions core/js/config.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,16 +109,16 @@ jeedom.config.locales = {
}

jeedom.config.save = function(_params) {
var paramsRequired = ['configuration'];
var paramsSpecifics = {};
const paramsRequired = ['configuration'];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/config.ajax.php';
paramsAJAX.data = {
action: 'addKey',
Expand All @@ -129,8 +129,8 @@ jeedom.config.save = function(_params) {
}

jeedom.config.load = function(_params) {
var paramsRequired = ['configuration'];
var paramsSpecifics = {
const paramsRequired = ['configuration'];
const paramsSpecifics = {
global: _params.global || true
};
try {
Expand All @@ -139,8 +139,8 @@ jeedom.config.load = function(_params) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/config.ajax.php';
paramsAJAX.data = {
action: 'getKey',
Expand All @@ -152,16 +152,16 @@ jeedom.config.load = function(_params) {
}

jeedom.config.remove = function(_params) {
var paramsRequired = ['configuration'];
var paramsSpecifics = {};
const paramsRequired = ['configuration'];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/config.ajax.php';
paramsAJAX.data = {
action: 'removeKey',
Expand All @@ -172,16 +172,16 @@ jeedom.config.remove = function(_params) {
}

jeedom.config.removeImage = function(_params) {
var paramsRequired = ['id'];
var paramsSpecifics = {};
const paramsRequired = ['id'];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/config.ajax.php';
paramsAJAX.data = {
action: 'removeImage',
Expand All @@ -197,7 +197,7 @@ jeedom.config.getGenericTypeModal = function(_options, callback) {
if (!isset(_options.type)) {
_options.type = 'info'
}
var url = 'index.php?v=d&modal=genericType.human.insert&type=' + _options.type
let url = 'index.php?v=d&modal=genericType.human.insert&type=' + _options.type
if (_options.object) url += '&object=' + _options.object

document.getElementById('mod_insertGenericType')?.remove()
Expand All @@ -216,7 +216,7 @@ jeedom.config.getGenericTypeModal = function(_options, callback) {
className: 'success',
callback: {
click: function(event) {
var args = {}
const args = {}
args.human = mod_insertGenericType.getValue()
args.id = mod_insertGenericType.getId()
if (args.human.trim() != '') {
Expand Down
24 changes: 12 additions & 12 deletions core/js/cron.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@
jeedom.cron = function() {};

jeedom.cron.setState = function(_params) {
var paramsRequired = ['id', 'state'];
var paramsSpecifics = {};
const paramsRequired = ['id', 'state'];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/cron.ajax.php';
paramsAJAX.data = {
action: _params.state,
Expand All @@ -36,16 +36,16 @@ jeedom.cron.setState = function(_params) {
}

jeedom.cron.all = function(_params) {
var paramsRequired = [];
var paramsSpecifics = {};
const paramsRequired = [];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/cron.ajax.php';
paramsAJAX.data = {
action: 'all'
Expand All @@ -54,16 +54,16 @@ jeedom.cron.all = function(_params) {
}

jeedom.cron.save = function(_params) {
var paramsRequired = ['crons'];
var paramsSpecifics = {};
const paramsRequired = ['crons'];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/cron.ajax.php';
paramsAJAX.data = {
action: 'save',
Expand Down
Loading
Loading