emit secondary tag handles (e.g. !!str) on Node::SetTag#1437
Open
c-tonneslan wants to merge 1 commit into
Open
emit secondary tag handles (e.g. !!str) on Node::SetTag#1437c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
When a node's tag started with "!!" — the YAML secondary tag handle,
as in "!!str" or "!!int" — EmitFromEvents stripped a single '!' and
emitted the rest as a LocalTag. The remaining string ("!str") then
failed the LocalTag character regex on the inner '!' and the emitter
bailed out with INVALID_TAG, truncating output after "!".
Reproduction from jbeder#1373:
YAML::Node root;
YAML::Node s{"hello"};
s.SetTag("!!str");
root["some_string"] = s;
root["some_int"] = 2;
std::cout << root; // -> "some_string: !"
Recognize the "!!" prefix in EmitProps and route it through
SecondaryTag with the rest of the tag content. After this:
some_string: !!str hello
some_int: 2
Added two regression tests under NodeTest covering both the secondary
("!!") and primary ("!") handle paths.
Closes jbeder#1373.
Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1373.
When a node's tag started with
!!(the YAML secondary tag handle, e.g.!!str),EmitFromEvents::EmitPropsstripped a single!and emitted the rest as aLocalTag. The remaining!strthen failed the local-tag character regex on its inner!and the emitter bailed out withINVALID_TAG, truncating the output:Route the
!!case throughSecondaryTagwith the rest of the tag content. After this:Two regression tests added under
NodeTestcovering both the secondary (!!) and primary (!) handle paths.