Repository navigation
chore: enable errorprone - #2326
Open
maxandersen wants to merge 2 commits into
Open
maxandersen wants to merge 2 commits into
maxandersen wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
maxandersen
changed the title
…ison Fixes 7 BoxedPrimitiveEquality bugs found by errorprone. Reference equality on Boolean works by accident for autoboxed values (cached) but fails for deserialized or explicitly constructed Boolean objects.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Error Prone static analysis.
Now that the build uses JDK 25, the original blocker (errorprone requires JDK 21+) is gone. This is just the 2-line addition — no toolchain or sourceSet changes needed.
net.ltgt.errorproneplugin v5.1.0error_prone_corev2.50.0Expected: CI will fail with 7
BoxedPrimitiveEqualityerrors (comparingBooleanwith==/!=instead of.equals()) — these are real bugs that will be fixed in follow-up commits.