Repository navigation
Conversation
Collaborator
|
As I said here I think it's expected behaviour that the setup view errors if no methods have been configured. I.e. you've mis-configured the app and it will not work. |
Author
|
Makes complete sense — thanks for taking a look and clarifying the design rationale! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
MethodForm.__init__,self.fields['method'].initialwas unconditionally assigned tomethod.choices[0][0]. When no methods are registered (or when all methods are unregistered),method.choicesis an empty list, leading to an unhandledIndexError: list index out of rangeand crashing the setup wizard when transitioning to themethodstep.Fix
method.initialwithif method.choices:.tests/test_forms.pyverifyingMethodForminitialization with an empty registry.tests/test_views_setup.pyverifyingSetupViewhandles an empty registry gracefully without raising an unhandled exception.Fixes #742.