Skip to content

Allow webauthn 3.x - #804

Closed
ghost wants to merge 1 commit into
masterfrom
unknown repository
Closed

ghost wants to merge 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Sep 12, 2026

Copy link
Copy Markdown

Currently webauthn>=2.0,<2.99 pins the WebAuthn extra to 2.x. Since webauthn 3.0.0 requires cbor2>=6.1.2, this also holds back cbor2.

As far as I can tell there is no incompatibility behind the cap — 3.0.0's release notes only list additions (PQC/ML-DSA algorithms, EdDSA preference, stricter CBOR duplicate-key rejection), and none of the helpers this package imports from webauthn, webauthn.helpers or webauthn.helpers.structs changed.

Test results on a718bc7, Python 3.14.6, Django 5.2.17:

webauthn / cbor2 result
2.8.0 / 5.9.0 169 tests OK (8 skipped, all YubiKey)
3.0.0 / 6.1.4 169 tests OK (8 skipped)

test_webauthn_attestation_and_assertion (Selenium + Chrome virtual authenticator) ran in both — not skipped — so registration and assertion are covered.

I normalised the cap style to <4 rather than keeping the <3.99 pattern used by the other extras — happy to change it back if you prefer consistency.

The webauthn extra was capped at <2.99, which also held back cbor2
because webauthn 3.0.0 requires cbor2>=6.1.2.

Full test suite passes on both 2.8.0/5.9.0 and 3.0.0/6.1.4, including
the Selenium virtual-authenticator end-to-end test.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

@claudep claudep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing this, I think we should go ahead with this if current tests are passing.

Repository owner closed this by deleting the head repository Sep 19, 2026
@claudep

claudep commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@moggers87 Should we reopen a new PR with this content (looks like the proposing user was deleted)?

@moggers87

Copy link
Copy Markdown
Collaborator

Yeah, probably. There's at least one security related change in 3.0.0: https://github.com/duo-labs/py_webauthn/blob/master/CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants