Skip to content

option to clear all releases from crontab #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
altherlex wants to merge 5 commits into
base: main
Choose a base branch
from
Open

option to clear all releases from crontab #613

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
744738d
option to clear all releases from crontab
altherlex Apr 25, 2016
a0731a1
Update command_line.rb
altherlex Dec 14, 2016
918a66e
Update version.rb
altherlex Dec 15, 2016
4912dd8
Update command_line.rb
altherlex Dec 15, 2016
6976e1d
Update whenever
altherlex Dec 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bin/whenever
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ OptionParser.new do |opts|
options[:clear] = true
options[:identifier] = identifier if identifier
end
opts.on('-a', '--clear-all-flags-crontab') do |identifier|
Copy link
Copy Markdown
Contributor

@olleolleolle olleolleolle Dec 15, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opts.on takes a third argument which is the user-visible documentation string for this option. Include one here.

We don't use the block argument, so I think you should remove it from this block.

options[:clear_all] = true
end
opts.on('-s', '--set [variables]', 'Example: --set \'environment=staging&path=/my/sweet/path\'') do |set|
options[:set] = set if set
end
Expand Down
12 changes: 11 additions & 1 deletion lib/whenever/command_line.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def initialize(options={})
exit(1)
end

if [@options[:update], @options[:write], @options[:clear]].compact.length > 1
if [@options[:update], @options[:write], @options[:clear], options[:clear_all]].compact.length > 1
warn("[fail] Can only update, write or clear. Choose one.")
Copy link
Copy Markdown
Contributor

@olleolleolle olleolleolle Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include "clear_all" in this warn message.

exit(1)
end
Expand All @@ -33,6 +33,16 @@ def initialize(options={})
def run
if @options[:update] || @options[:clear]
write_crontab(updated_crontab)
elsif @options[:clear_all]
# Create a file if doesn't exist
system "crontab -l | sed 's/>/>>/' | crontab - "
# Remove crontab
system "crontab -r"
# Reinitialize
system "crontab -l | sed 's/>/>>/' | crontab - "

puts '[reset] Success to reboot crontab'
exit(0)
elsif @options[:write]
write_crontab(whenever_cron)
else
Expand Down