Skip to content

Fixes #5480: clear when re-inverting an 'in' Op #5501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdeforest wants to merge 2 commits into
base: main
Choose a base branch
from
+32 −2
Open

Fixes #5480: clear when re-inverting an 'in' Op #5501

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d62be82
Fixes #5480: clear when re-inverting an 'in' Op
Jun 3, 2026
4b48f35
test/operators: change switch subjects to boolean so they match the t…
Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/coffeescript/nodes.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/nodes.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4686,7 +4686,10 @@ exports.Op = class Op extends Base

invert: ->
if @isInOperator()
@invertOperator = '!'
if @invertOperator
@invertOperator = undefined
else
@invertOperator = '!'
return @
if @isChain()
allInvertable = yes
Expand Down
23 changes: 23 additions & 0 deletions test/operators.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,3 +451,26 @@ test "'new' target", ->

# classes must be called with `new`. In this case `new` applies to `get` only
throws -> new get()()

test "#5480: 'when a not in b'", ->
needle = "needle"
hayStack = []
needleStack = [needle]

switch
when needle in hayStack then ok false
switch
when needle not in hayStack then ok true
switch
when needle in needleStack then ok true
switch
when needle not in needleStack then ok false

switch "with subject"
when needle in hayStack then ok false
switch "with subject"
when needle not in hayStack then ok true
switch "with subject"
when needle in needleStack then ok true
switch "with subject"
when needle not in needleStack then ok false

@Inve1951 Inve1951 Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these switch constructs always hit the default branch because the string is never a boolean

@rdeforest rdeforest Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I updated the tests by adding "and true" after all the strings.

Loading