build: make icons-hash-gen a proper target#2142
Conversation
The generator needs to run on the build/host system, not the target one. So I'm not sure why you would want to cross compile it. Can you elaborate a bit more about what problem this solves? |
|
It's easier to compile native icons-hash-gen with a proper target. |
If I understood correctly, instead of just running I've actually thought about using |
That's it
CC_BUILD can't be used as-is and requires additional handling. |
|
@N-R-K is this good to go? |
|
|
||
| src/$(ICONS_INCLUDE): src/icons-hash.c src/icons.h src/icons-in-terminal.h | ||
| $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) -DICONS_GENERATE -o src/icons-hash-gen src/icons-hash.c | ||
| src/icons-hash-gen: src/icons-hash.c |
There was a problem hiding this comment.
This needs to depend on src/icons.h and src/icons-in-terminal.h as well otherwise generator will be using outdated icons.
so it can be cross-compiled easier Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
EDIT: so the project can be cross-compiled easier