Cleanup phpstan baseline issues

.phpstan-no-baseline.neon

@@ -0,0 +1,7 @@
+parameters:
+    level: 8
+    paths:
+        - src
+        - tests
+    excludePaths:
+        - src/Kernel.php

CHANGELOG.md

@@ -8,14 +8,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+* [PR-308](https://github.com/itk-dev/economics/pull/308)
+  * PHPStan baseline cleanup in src/ (530 → 0); behavior- and schema-affecting items below.
+  * Migrations Version20260517131038 and Version20260517151632: relaxed 18 columns and
+    11 ManyToOne FKs on synced entities (issue, project, version, worklog) to nullable
+    to match property types; application-layer asserts/form validators still enforce required-ness.
+  * Fixed report services crashing on worklogs with null project/issue and rendering empty epic
+    tags (Epic::getName() → getTitle()); fixed SubscriptionHandlerService::getVersion()
+    lookup by non-existent field.
+  * LeantimeApiService switched from object to array json_decode; wire shape unchanged.
+
 ## [3.5.0] - 2026-05-26
 
 * [PR-315](https://github.com/itk-dev/economics/pull/315)
   * Add tidy-feedback collector module.
 * [PR-310](https://github.com/itk-dev/economics/pull/310)
   * Remove dataProvider scoping.
 * [PR-264](https://github.com/itk-dev/economics/pull/264)
-  Added cybersecurity report.
+  * Added cybersecurity report.
 * [PR-309](https://github.com/itk-dev/economics/pull/309)
   * Consolidated project and service-agreement fields.
   * Moved the Leantime project link from service agreement to project and rendered it via a Twig helper.

migrations/Version20260517131038.php

@@ -0,0 +1,41 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DoctrineMigrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+/**
+ * Auto-generated Migration: Please modify to your needs!
+ */
+final class Version20260517131038 extends AbstractMigration
+{
+    public function getDescription(): string
+    {
+        return 'Make columns nullable on synced entities (issue/project/version/worklog) and on app-managed DateTime fields (project_billing period_start/end, service_agreement valid_from) to match PHP property types.';
+    }
+
+    public function up(Schema $schema): void
+    {
+        // this up() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE issue CHANGE name name VARCHAR(255) DEFAULT NULL, CHANGE project_tracker_id project_tracker_id VARCHAR(255) DEFAULT NULL, CHANGE project_tracker_key project_tracker_key VARCHAR(255) DEFAULT NULL, CHANGE link_to_issue link_to_issue VARCHAR(255) DEFAULT NULL');
+        $this->addSql('ALTER TABLE project CHANGE name name VARCHAR(255) DEFAULT NULL, CHANGE project_tracker_project_url project_tracker_project_url VARCHAR(255) DEFAULT NULL, CHANGE project_tracker_key project_tracker_key VARCHAR(255) DEFAULT NULL');
+        $this->addSql('ALTER TABLE project_billing CHANGE period_start period_start DATETIME DEFAULT NULL, CHANGE period_end period_end DATETIME DEFAULT NULL');
+        $this->addSql('ALTER TABLE service_agreement CHANGE valid_from valid_from DATETIME DEFAULT NULL');
+        $this->addSql('ALTER TABLE version CHANGE name name VARCHAR(255) DEFAULT NULL, CHANGE project_tracker_id project_tracker_id VARCHAR(255) DEFAULT NULL, CHANGE is_billable is_billable TINYINT(1) DEFAULT NULL');
+        $this->addSql('ALTER TABLE worklog CHANGE worklog_id worklog_id INT DEFAULT NULL, CHANGE worker worker VARCHAR(255) DEFAULT NULL, CHANGE time_spent_seconds time_spent_seconds INT DEFAULT NULL, CHANGE started started DATETIME DEFAULT NULL, CHANGE project_tracker_issue_id project_tracker_issue_id VARCHAR(255) DEFAULT NULL');
+    }
+
+    public function down(Schema $schema): void
+    {
+        // this down() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE project CHANGE name name VARCHAR(255) NOT NULL, CHANGE project_tracker_project_url project_tracker_project_url VARCHAR(255) NOT NULL, CHANGE project_tracker_key project_tracker_key VARCHAR(255) NOT NULL');
+        $this->addSql('ALTER TABLE worklog CHANGE worklog_id worklog_id INT NOT NULL, CHANGE worker worker VARCHAR(255) NOT NULL, CHANGE time_spent_seconds time_spent_seconds INT NOT NULL, CHANGE started started DATETIME NOT NULL, CHANGE project_tracker_issue_id project_tracker_issue_id VARCHAR(255) NOT NULL');
+        $this->addSql('ALTER TABLE project_billing CHANGE period_start period_start DATETIME NOT NULL, CHANGE period_end period_end DATETIME NOT NULL');
+        $this->addSql('ALTER TABLE version CHANGE name name VARCHAR(255) NOT NULL, CHANGE project_tracker_id project_tracker_id VARCHAR(255) NOT NULL, CHANGE is_billable is_billable TINYINT(1) NOT NULL');
+        $this->addSql('ALTER TABLE service_agreement CHANGE valid_from valid_from DATETIME NOT NULL');
+        $this->addSql('ALTER TABLE issue CHANGE name name VARCHAR(255) NOT NULL, CHANGE project_tracker_id project_tracker_id VARCHAR(255) NOT NULL, CHANGE project_tracker_key project_tracker_key VARCHAR(255) NOT NULL, CHANGE link_to_issue link_to_issue VARCHAR(255) NOT NULL');
+    }
+}

migrations/Version20260517151632.php

@@ -0,0 +1,45 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DoctrineMigrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+/**
+ * Auto-generated Migration: Please modify to your needs!
+ */
+final class Version20260517151632 extends AbstractMigration
+{
+    public function getDescription(): string
+    {
+        return 'Make ManyToOne foreign keys nullable on entities whose properties are typed nullable. Aligns DB schema with PHP property types; application/validation layer still enforces required-ness on app-managed entities.';
+    }
+
+    public function up(Schema $schema): void
+    {
+        // this up() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE cybersecurity_agreement CHANGE service_agreement_id service_agreement_id INT DEFAULT NULL');
+        $this->addSql('ALTER TABLE invoice_entry CHANGE invoice_id invoice_id INT DEFAULT NULL');
+        $this->addSql('ALTER TABLE issue_product CHANGE issue_id issue_id INT DEFAULT NULL, CHANGE product_id product_id INT DEFAULT NULL');
+        $this->addSql('ALTER TABLE product CHANGE project_id project_id INT DEFAULT NULL');
+        $this->addSql('ALTER TABLE project_billing CHANGE project_id project_id INT DEFAULT NULL');
+        $this->addSql('ALTER TABLE service_agreement CHANGE project_id project_id INT DEFAULT NULL, CHANGE client_id client_id INT DEFAULT NULL, CHANGE project_lead_id project_lead_id INT DEFAULT NULL');
+        $this->addSql('ALTER TABLE version CHANGE project_id project_id INT DEFAULT NULL');
+        $this->addSql('ALTER TABLE worklog CHANGE issue_id issue_id INT DEFAULT NULL');
+    }
+
+    public function down(Schema $schema): void
+    {
+        // this down() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE invoice_entry CHANGE invoice_id invoice_id INT NOT NULL');
+        $this->addSql('ALTER TABLE worklog CHANGE issue_id issue_id INT NOT NULL');
+        $this->addSql('ALTER TABLE product CHANGE project_id project_id INT NOT NULL');
+        $this->addSql('ALTER TABLE issue_product CHANGE issue_id issue_id INT NOT NULL, CHANGE product_id product_id INT NOT NULL');
+        $this->addSql('ALTER TABLE project_billing CHANGE project_id project_id INT NOT NULL');
+        $this->addSql('ALTER TABLE version CHANGE project_id project_id INT NOT NULL');
+        $this->addSql('ALTER TABLE service_agreement CHANGE project_id project_id INT NOT NULL, CHANGE client_id client_id INT NOT NULL, CHANGE project_lead_id project_lead_id INT NOT NULL');
+        $this->addSql('ALTER TABLE cybersecurity_agreement CHANGE service_agreement_id service_agreement_id INT NOT NULL');
+    }
+}